Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make metadata not show in the manifest if nil #74

Merged
merged 2 commits into from
Oct 3, 2022
Merged

make metadata not show in the manifest if nil #74

merged 2 commits into from
Oct 3, 2022

Conversation

kirkkwang
Copy link
Contributor

According to pres 3 specs,

The value of the metadata property must be an array of JSON objects...

At the moment if there are no metadata, the metadata field is set to null which will thrown an error on the validator.

image

  • add guard for metadata so it will not appear if nil

cjcolvar
cjcolvar reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Could you please add a test for this to make sure we don't have regressions in the future?

@kirkkwang
Copy link
Contributor Author

Can do!

@cjcolvar cjcolvar merged commit 94d45c0 into main Oct 3, 2022
@cjcolvar cjcolvar deleted the fix-metadata-nil branch October 3, 2022 17:53
@kirkkwang
Copy link
Contributor Author

accidentally change something because i misread it, fix here: #75

@cjcolvar cjcolvar mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkkwang @cjcolvar